jtibshirani commented on a change in pull request #736:
URL: https://github.com/apache/lucene/pull/736#discussion_r828330417
##########
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestIndexSortSortedNumericDocValuesRangeQuery.java
##########
@@ -459,54 +461,55 @@ public void
testIndexSortOptimizationDeactivated(RandomIndexWriter writer) throw
reader.close();
}
- public void testCount() throws IOException {
+ public void testCountHasMissingValue() throws IOException {
Review comment:
It could be really helpful to add another test like
`testSameHitsAsPointRangeQuery` that compares the counts of the two queries.
Also in `testSameHitsAsPointRangeQuery` I noticed that we always set
`sortField.setMissingValue(random().nextLong())`, it'd be great to randomize
this more -- sometimes not setting it at all, sometimes setting it to
`Long.MIN_VALUE` or `Long.MAX_VALUE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
