[ 
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534117#comment-17534117
 ] 

Robert Muir commented on LUCENE-9356:
-------------------------------------

by the way, if we just want to improve the exception path, test the real 
corruption path, it is probably more practical for test to modify {{checksum}} 
of the file rather than random byte flip. You still have the issue of 
collisions, but maybe it is more straightforward to test it in this way?

> Add tests for corruptions caused by byte flips
> ----------------------------------------------
>
>                 Key: LUCENE-9356
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9356
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Adrien Grand
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We already have tests that file truncation and modification of the index 
> headers are caught correctly. I'd like to add another test that flipping a 
> byte in a way that modifies the checksum of the file is always caught 
> gracefully by Lucene.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to