[ 
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534216#comment-17534216
 ] 

Adrien Grand commented on LUCENE-9356:
--------------------------------------

This test does try to account for CRC32 collisions, it runs checksumEntireFile 
after doing a byte flip, and then returns if checksumEntireFile returned 
successfully, which would indicate a CRC32 collision? That said, I agree with 
your suggestions and opened https://github.com/apache/lucene/pull/876.

> Add tests for corruptions caused by byte flips
> ----------------------------------------------
>
>                 Key: LUCENE-9356
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9356
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Adrien Grand
>            Priority: Minor
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> We already have tests that file truncation and modification of the index 
> headers are caught correctly. I'd like to add another test that flipping a 
> byte in a way that modifies the checksum of the file is always caught 
> gracefully by Lucene.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to