benwtrent commented on PR #12729:
URL: https://github.com/apache/lucene/pull/12729#issuecomment-1785376897
@jpountz the goal of this change is not just making code reusable. But:
- Allowing folks who don't want HNSW to take advantage of the per-segment
quantization and logic. Paging in float32 values, even when not using HNSW, can
take time and memory. Reducing the size and just using `byte` values is really
attractive.
- being able to plugin a different flat storage no matter the vector
indexer is useful as I would think we will want to add other quantizations in
the future (e.g. `bfloat16`).
I suppose your suggestion around separate HNSW formats with flat storage
hardcoded can still satisfy my second point, as long as the classes are usable.
But, I would really like to not lose the first goal, making quantization
available to users who want flat vector storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
