benwtrent commented on PR #12729:
URL: https://github.com/apache/lucene/pull/12729#issuecomment-1785563758
OK, @jpountz thinking about it more. To do what you are suggesting, I think
the following would work:
- Force Lucene99HnswVectorsReader & Lucene99HnswVectorsWriter to take a
`FlatVectors[Read|Writer]`. This way the hard coded `*Format` files can reuse
all the common code.
- Remove the SPI the formats are now required to indicate how the vectors
are stored and read
- Remove the inheritance tree for the `FlatVector*` things so that they are
not `knn` things.
In a separate PR I guess we can talk about a "flat" vector codec and if that
is desired or not.
The "*Flat" things now get users very far, they just need to have a custom
codec that provides a couple lines of code to forward the searching, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
