cpoerschke commented on code in PR #13757: URL: https://github.com/apache/lucene/pull/13757#discussion_r1753459010
########## lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java: ########## @@ -113,6 +114,19 @@ protected Similarity() {} */ public abstract long computeNorm(FieldInvertState state); + /** TODO */ + protected static long doComputeNorm(FieldInvertState state, boolean discountOverlaps) { Review Comment: Not sure how best to javadoc(ument) this, suggestions welcome. Also perhaps this could be a static method in the `FieldInvertState` class instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org