rmuir commented on PR #13757: URL: https://github.com/apache/lucene/pull/13757#issuecomment-2343239722
I would also be in favor of adding some kind of warning/note, to the `computeNorm`: "expert: if you change this, index will not be different and not compatible with other similarities/require reindexing to change" and to the constructor taking the bool? Idea is just that user extends Similarity and it "works", but other things are still possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
