cpoerschke commented on PR #13757: URL: https://github.com/apache/lucene/pull/13757#issuecomment-2343423491
> the straightforward way would be to add: > > * Similarity(boolean) > * Similarity() -> this(true) > * add getter (only), no setter. this is also duplicated in subclasses. > > For me this stuff is ok, because we are making the tradeoff to simplify just the index-time side of this thing, by giving it a default implementation. https://github.com/apache/lucene/pull/13757/commits/cbab8fb55c5eb2eca58032ed17c58a380c92d18e is a variation of that i.e. no changes to the constructor signature. I'm still investigating w.r.t. some subclasses having setters and how that would interact with the constructor taking a boolean too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
