romseygeek commented on code in PR #15663:
URL: https://github.com/apache/lucene/pull/15663#discussion_r2767925292
##########
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##########
@@ -361,8 +385,8 @@ void setScorer(Scorable scorer) throws IOException {
}
@Override
- int docCount() {
- return pointValues.getDocCount();
+ protected boolean hasMissingDocs() {
+ return pointValues.getDocCount() != maxDoc;
}
Review Comment:
We have two internal implementations, one of which uses points and one which
uses skippers, and they each detect missing docs in different ways. So this
needs to be overridden depending on which data structure the competitive
iterator builder is using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
