renatoh commented on PR #15682:
URL: https://github.com/apache/lucene/pull/15682#issuecomment-3871813098

   > I think targeting 11.0 is fine, if you want it in next minor relaese, 
please move the changes entry. But Lucene 10.4 is already time over, we're in 
release process, so next could be 10.5.
   
   No need to move it to 10.5, I came across this LinkedList coincidentally 
debugging  HyphenationCompoundWordTokenFilter
   
   Looking where else LinkedList is used, and potentially miss-used as a Queue, 
I came across this case:
   org.apache.lucene.index.DocumentsWriterFlushControl#flushQueue
   it is literally called Queue and used on the Queue interface, but the 
instance is a LinkedList.
   Do you think it would make sense to scan the code base for that pattern and 
change these cases to ArrayDeque as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to