renatoh commented on PR #15682: URL: https://github.com/apache/lucene/pull/15682#issuecomment-3872687861
forbiddenapi, isn't that a bit too strict? what if the niche case occurs where it make sense? A LinkedList does allow null-element, ArrayDeque does not, dq.add(null) throws and NPE. That could introduce some issues, how much do you trust the unit-test to catch these cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
