uschindler commented on PR #15682: URL: https://github.com/apache/lucene/pull/15682#issuecomment-3873075094
That of course also requires review, but we did similar things with moving from unmodifiableXxx to Map/Set/List.of(). We had no null issues so it is unlikely. But you have to check this. If a unit test does not catch zthis its a bug anyways, because at places where we allow null elements we normally have a test, too. We have forbiddenapis for Stack/Vector already: https://github.com/apache/lucene/blob/6d9917b13c83bee3daae1c53f810dc2779730e9b/gradle/validation/forbidden-apis/all/defaults.txt#L42-L43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
