renatoh commented on PR #15682: URL: https://github.com/apache/lucene/pull/15682#issuecomment-3873718825
@uschindler but there are niche cases, for which LL will be an appropriate choice. Checking all the usage of LL, I belief I came across two instance, for which could make sense to stick to the LL: FieldTermStack-> poll and push of the LL is used, and the LL is sorted at one point. ArrayList will have worse performacne for poll and push, ArrayDeque cannot be sorted. SynonymGraphFilter.outputBuffer -> switching this to an ArrayList is a trade off, outputBuffer.get(pathID).endNode will be faster outputBuffer.pollFirst() - removeFirst for an ArrayList - will be slower., but it feels like ArrayList is the way to go since access via index is done in a loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
