iprithv commented on code in PR #16103:
URL: https://github.com/apache/lucene/pull/16103#discussion_r3339953213


##########
lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java:
##########
@@ -2669,9 +2669,11 @@ protected void onCacheEntryEvicted(Object readerCoreKey, 
Query query, long ramBy
           }
         };
 
-    // Force exactly 1 segment so cache behavior is deterministic

Review Comment:
   ah, did I misunderstand? so these comments 
   
   ```
   // Use a non-randomized IndexWriterConfig to prevent randomized flush 
thresholds
   // (e.g., tiny RAM buffer) from splitting 3 docs into multiple segments.
   ```
   
   can be removed entirely? If so, I'll remove them.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to