romseygeek commented on code in PR #16103:
URL: https://github.com/apache/lucene/pull/16103#discussion_r3340005299
##########
lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java:
##########
@@ -2669,9 +2669,11 @@ protected void onCacheEntryEvicted(Object readerCoreKey,
Query query, long ramBy
}
};
- // Force exactly 1 segment so cache behavior is deterministic
Review Comment:
I don't understand why the test is changing at all? If it's a genuine bug
in the test can we have it in a separate PR as it's unrelated to the changes in
DisjunctionMaxQuery IIUC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
