kkewwei commented on code in PR #16515:
URL: https://github.com/apache/lucene/pull/16515#discussion_r3804472962
##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -301,14 +305,23 @@ private void collectEssentialScoresIntoWindow(
FixedBitSet filterMatches)
throws IOException {
do {
- for (top.scorer.nextDocsAndScores(innerWindowMax, acceptDocs,
docAndScoreBuffer);
+ for (nextDocsAndScores(
Review Comment:
Creating a FilterBits also seems like a reasonable approach. If you're okay
with it, I'll make the change accordingly.
##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -301,14 +305,23 @@ private void collectEssentialScoresIntoWindow(
FixedBitSet filterMatches)
throws IOException {
do {
- for (top.scorer.nextDocsAndScores(innerWindowMax, acceptDocs,
docAndScoreBuffer);
+ for (nextDocsAndScores(
Review Comment:
Creating a `FilterBits` also seems like a reasonable approach. If you're
okay with it, I'll make the change accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
