kkewwei commented on code in PR #16515:
URL: https://github.com/apache/lucene/pull/16515#discussion_r3804372792
##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -234,7 +234,11 @@ private void fillScoreBufferViaBitSet(DisiWrapper top,
Bits acceptDocs, int inne
filter.doc = filter.approximation.advance(innerWindowMin);
}
if (filter.doc < innerWindowMax) {
- filter.approximation.intoBitSet(innerWindowMax, filterMatches,
innerWindowMin);
+ if (filter.twoPhaseView != null) {
Review Comment:
Get it.
##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -301,14 +305,23 @@ private void collectEssentialScoresIntoWindow(
FixedBitSet filterMatches)
throws IOException {
do {
- for (top.scorer.nextDocsAndScores(innerWindowMax, acceptDocs,
docAndScoreBuffer);
+ for (nextDocsAndScores(
Review Comment:
Given that `acceptDocs` and `filterMatches` are never used simultaneously,
it seems unnecessary to encapsulate them together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
