kaivalnp commented on PR #16654: URL: https://github.com/apache/lucene/pull/16654#issuecomment-5593342777
One issue with this change: users won't be able to subclass the queries and override functions (for example [`approximateSearch`](https://github.com/apache/lucene/blob/c2c83bcd2b2d045b8ce0e811582544273add7026/lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java#L138)). I wonder if we should create new classes entirely, or keep initialization constructor-based? (and let users discover the breakage through their tests) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
