kaivalnp commented on PR #16654: URL: https://github.com/apache/lucene/pull/16654#issuecomment-5607489166
Thanks for the feedback @hossman. I changed the static factory methods to named inner classes (`Explicit` and `Adaptive`) to support overriding functions, which is basically like changing the name of the classes, but less invasive IMO. i.e. all instances of the query prior to Lucene 10.5 (like `new FloatVectorSimilarityQuery(...)`) can be replaced with a deprecated equivalent (like `new FloatVectorSimilarityQuery.Explicit(...)`), which will be removed in a future release, and meant to be replaced by an adaptive version (like `new FloatVectorSimilarityQuery.Adaptive(...)`) with a different behavior. One thing remaining in this PR: tests on `main` are written with the "adaptive" version in mind, so the old "explicit" query needs some of its own. Also TBD: when can we remove the "explicit" version? Should 10.6 be okay, given the query is marked `@lucene.experimental`, and we want to avoid maintaining two versions? Also cc release manager of 10.5.2 (@msokolov) for opinions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
