kaivalnp commented on PR #16654:
URL: https://github.com/apache/lucene/pull/16654#issuecomment-5626289064
Also pasting `git diff` between `VectorSimilarityCollector` on `branch_10_4`
and `ExplicitVectorSimilarityCollector` in this PR:
```diff
diff --git
a/lucene/core/src/java/org/apache/lucene/search/VectorSimilarityCollector.java
b/lucene/core/src/java/org/apache/lucene/search/ExplicitVectorSimilarityCollector.java
index 0c0036c20e4..72eec5e231b 100644
---
a/lucene/core/src/java/org/apache/lucene/search/VectorSimilarityCollector.java
+++
b/lucene/core/src/java/org/apache/lucene/search/ExplicitVectorSimilarityCollector.java
@@ -22,9 +22,11 @@ import java.util.List;
/**
* Perform a similarity-based graph search.
*
+ * @deprecated Use {@link VectorSimilarityCollector} for a more performant
version.
* @lucene.experimental
*/
-class VectorSimilarityCollector extends AbstractKnnCollector {
+@Deprecated
+class ExplicitVectorSimilarityCollector extends AbstractKnnCollector {
private final float traversalSimilarity, resultSimilarity;
private float maxSimilarity;
private final List<ScoreDoc> scoreDocList;
@@ -38,7 +40,7 @@ class VectorSimilarityCollector extends
AbstractKnnCollector {
* @param resultSimilarity (higher) similarity score for result
collection.
* @param visitLimit limit on number of nodes to visit.
*/
- public VectorSimilarityCollector(
+ public ExplicitVectorSimilarityCollector(
float traversalSimilarity, float resultSimilarity, long visitLimit) {
// TODO: add search strategy support
super(1, visitLimit, AbstractVectorSimilarityQuery.DEFAULT_STRATEGY);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
