[
https://issues.apache.org/jira/browse/SUREFIRE-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14875787#comment-14875787
]
ASF GitHub Bot commented on SUREFIRE-1177:
------------------------------------------
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/105#issuecomment-141484326
LGTM but missing ITs.
You can use the one in Jira and create new for testsuites. See how the ITs
are written in surefire-integration-tests module. I guess you already have the
experiences.
We have to update documentation regarding parallel exec in TestNG with use
of these parameters and trivial use cases for each.
As a hint for `dataproviderthreadcount` you can print
`ConcurrentHashMap#size()` and assert that string `concurrency=30.` appears in
console lines. You would need to put a little delay 100 millis where iterations
1000 would be enough to have.
This way you do not need any performance test - no need to assert exec time
which is always dependent on CPU in build park.
Regarding `suitethreadpoolsize` is there any way to print verbose
configuration by TestNG?
Other possibility would be to implement `ITestListener` remember time of
the first `onStart` and time of last `oninish` and compute the diff time. This
would be the performance test, but it may vary 1.0 sec in overloaded build park.
One way or another the IT should assert that all suites run successfully.
> TestNG "suitethreadpoolsize" parameter can not be set by Maven Surefire
> -----------------------------------------------------------------------
>
> Key: SUREFIRE-1177
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1177
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.18.1
> Reporter: Jan Dundáček
>
> Because of Surefire is using deprecated TestNG.configure(Map) method,
> parameter "suitethreadpoolsize" value is not read by TestNG. And so test
> suites can not be run in parallel. This parameter is read only in
> TestNG.configure(CommandLineArgs) method.
> /**
> * This method is invoked by Maven's Surefire to configure the runner,
> * do not remove unless you know for sure that Surefire has been updated
> * to use the new configure(CommandLineArgs) method.
> *
> * @deprecated use new configure(CommandLineArgs) method
> */
> @Deprecated
> public void configure(Map cmdLineArgs) {
> ....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
