[
https://issues.apache.org/jira/browse/SUREFIRE-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877328#comment-14877328
]
ASF GitHub Bot commented on SUREFIRE-1177:
------------------------------------------
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/105#issuecomment-141709744
Are we agree that the current PR is more about parameters than threading?
Before the fix: "-suitethreadpoolsize" and "-dataproviderthreadcount" were
sent without conversion to TestNG, but TestNG need `Integer`.
After the fix: "-suitethreadpoolsize" and "-dataproviderthreadcount" are
sent with conversion to TestNG, what it supposed to be done.
@dundacek already made [a fix](https://github.com/cbeust/testng/pull/798)
into TestNG for "-suitethreadpoolsize" but not for "-dataproviderthreadcount".
And I think we are all agree that TestNG is not the good place for that.
What I propose is to merge my fix because it has no risk
("-suitethreadpoolsize" and "-dataproviderthreadcount" are `Integer` since the
begginning) and it will help users, then we can try to improve parallel and/or
use the "new" TestNG method.
> TestNG "suitethreadpoolsize" parameter can not be set by Maven Surefire
> -----------------------------------------------------------------------
>
> Key: SUREFIRE-1177
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1177
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.18.1
> Reporter: Jan Dundáček
>
> Because of Surefire is using deprecated TestNG.configure(Map) method,
> parameter "suitethreadpoolsize" value is not read by TestNG. And so test
> suites can not be run in parallel. This parameter is read only in
> TestNG.configure(CommandLineArgs) method.
> /**
> * This method is invoked by Maven's Surefire to configure the runner,
> * do not remove unless you know for sure that Surefire has been updated
> * to use the new configure(CommandLineArgs) method.
> *
> * @deprecated use new configure(CommandLineArgs) method
> */
> @Deprecated
> public void configure(Map cmdLineArgs) {
> ....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
