[
https://issues.apache.org/jira/browse/SUREFIRE-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900003#comment-14900003
]
ASF GitHub Bot commented on SUREFIRE-1177:
------------------------------------------
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/105#issuecomment-141812040
Agreed, we can improve later on.
Then the TestNG project should be informed that we continue using old
configuration method.
I have to ask you guys to publish documentation in
maven-surefire-plugin project src/main/site/**/*.apt.vm with both
examples for "-suitethreadpoolsize" and "-dataproviderthreadcount".
I will commit the fix as soon as you introduce integration tests for
all configurations.
Please make sure that we hit more than 10 concurrent threads.
Make sure that sanity check throws TestSetFailedException with
meaningful message that "-suitethreadpoolsize" or
"-dataproviderthreadcount" should be positive integer.
On 9/19/15, Julien Herr <notificati...@github.com> wrote:
> Are we agree that the current PR is more about parameters than threading?
>
> Before the fix: "-suitethreadpoolsize" and "-dataproviderthreadcount" were
> sent without conversion to TestNG, but TestNG need `Integer`.
> After the fix: "-suitethreadpoolsize" and "-dataproviderthreadcount" are
> sent with conversion to TestNG, what it supposed to be done.
>
> @dundacek already made [a fix](https://github.com/cbeust/testng/pull/798)
> into TestNG for "-suitethreadpoolsize" but not for
> "-dataproviderthreadcount". And I think we are all agree that TestNG is
not
> the good place for that.
>
> What I propose is to merge my fix because it has no risk
> ("-suitethreadpoolsize" and "-dataproviderthreadcount" are `Integer` since
> the begginning) and it will help users, then we can try to improve
parallel
> and/or use the "new" TestNG method.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/maven-surefire/pull/105#issuecomment-141709744
--
Cheers
Tibor
> TestNG "suitethreadpoolsize" parameter can not be set by Maven Surefire
> -----------------------------------------------------------------------
>
> Key: SUREFIRE-1177
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1177
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.18.1
> Reporter: Jan Dundáček
>
> Because of Surefire is using deprecated TestNG.configure(Map) method,
> parameter "suitethreadpoolsize" value is not read by TestNG. And so test
> suites can not be run in parallel. This parameter is read only in
> TestNG.configure(CommandLineArgs) method.
> /**
> * This method is invoked by Maven's Surefire to configure the runner,
> * do not remove unless you know for sure that Surefire has been updated
> * to use the new configure(CommandLineArgs) method.
> *
> * @deprecated use new configure(CommandLineArgs) method
> */
> @Deprecated
> public void configure(Map cmdLineArgs) {
> ....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
