[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478673#comment-16478673
 ] 

ASF GitHub Bot commented on SCM-885:
------------------------------------

michael-o commented on a change in pull request #72: [SCM-885] second 
implementation with new API
URL: https://github.com/apache/maven-scm/pull/72#discussion_r188864134
 
 

 ##########
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/CommandParameter.java
 ##########
 @@ -50,6 +50,8 @@
 
     public static final CommandParameter BRANCH = new CommandParameter( 
"branch" );
 
+    public static final CommandParameter START_FROM_ROOT = new 
CommandParameter( "startFromRoot" );
 
 Review comment:
   But isn't that the end, not the start? You are giving one ref from which log 
goes back in time, doesn't it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> --------------------------------------------------------
>
>                 Key: SCM-885
>                 URL: https://issues.apache.org/jira/browse/SCM-885
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.9.5
>            Reporter: Matthieu Brouillard
>            Priority: Major
>             Fix For: waiting-for-feedback
>
>         Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to