[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479030#comment-16479030
 ] 

Matthieu Brouillard commented on SCM-885:
-----------------------------------------

{quote}The usecase ..END is covered by START..END where START hast to be 
provided as HEAD explicitly
{quote}
you refused the initial PR that was assuming the same for both {{..END}} & 
{{START..}} because it was introducing a non compatible change. I do not 
understand anymore.
{quote}The last usecase for is that SCM_VERSION is END_SCM_VERSION, I'd expect 
users to provide HEAD to avoid ambiguity.
{quote}
I don't understand the sentence. Given the table above there is no ambiguity 
anymore because if any of the {{START_SCM_VERSION}} or {{END_SCM_VERSION}} is 
provided then it is the syntax {{A..B}} that will be used even if any of A or B 
is ommited (null).

{{git whatchanged VERSION}} will only be issued when and only when both 
{{START_SCM_VERSION}} and {{END_SCM_VERSION}} are null

I'll provide another PR that implements the table.

> GitChangeLogCommand is wrong when only endVersion is set
> --------------------------------------------------------
>
>                 Key: SCM-885
>                 URL: https://issues.apache.org/jira/browse/SCM-885
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.9.5
>            Reporter: Matthieu Brouillard
>            Priority: Major
>             Fix For: waiting-for-feedback
>
>         Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to