[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478794#comment-16478794
]
Matthieu Brouillard commented on SCM-885:
-----------------------------------------
{quote}The more I think about it....
{noformat}
START..
START..END
END
{noformat}{quote}
That's a bit what I initialy wanted to do with the initial PR.
But then how would you differenciate {{..END}} from {{END}} by the usage for
the later of {{CommandParameter.SCM_VERSION}} instead of
{{CommandParameter.END_SCM_VERSION}}?
Now that I have a better overview of the code, I think it could be the best
solution.
This will end for changelog command in git world:
||START_SCM_VERSION||END_SCM_VERSION||SCM_VERSION||git whatchanged
parameters||Description||
| A | B | any, not used | A..B | commits between B and A, A being an ancestor
of B otherwise empty, without A |
| null | B | any, not used | ..B | commits between B and HEAD, HEAD being an
ancestor of B otherwise empty, without HEAD |
| A | null | any, not used | A.. | commits between HEAD and A, A being an
ancestor of HEAD otherwise empty, without A |
| null | null | V | V | all ancestor commits starting from V |
Do you agree that it is the way to go?
> GitChangeLogCommand is wrong when only endVersion is set
> --------------------------------------------------------
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
> Affects Versions: 1.9.5
> Reporter: Matthieu Brouillard
> Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
