mthmulders commented on a change in pull request #51:
URL: https://github.com/apache/maven-resolver/pull/51#discussion_r427053009
##########
File path:
maven-resolver-api/src/test/java/org/eclipse/aether/repository/AuthenticationContextTest.java
##########
@@ -56,7 +56,7 @@ public void fill( AuthenticationContext context, String key,
Map<String, String>
assertNotNull( context );
assertNotNull( context.getSession() );
assertNotNull( context.getRepository() );
- assertNull( "fill() should only be called once", context.get(
"key" ) );
+ //assertNull( "fill() should only be called once",
context.get( "key" ) );
Review comment:
I don't feel like we should disable assertions by commenting them. Also,
I don't feel like we should disable assertions at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
