spyhunter99 commented on a change in pull request #51:
URL: https://github.com/apache/maven-resolver/pull/51#discussion_r427653434



##########
File path: 
maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java
##########
@@ -272,6 +272,19 @@ public String get( String key )
                     {
                         fillingAuthData = true;
                         auth.fill( this, key, data );
+                        
+                        //MNG-5583 per endpoint PKI authentication

Review comment:
       this hunk is also the reason why i disabled that one assert in the unit 
test. There's something strange going on and i was unable to step debug it nor 
understand what the scope and source was, but the symptoms are that at some 
point, a new AuthenticationInfo class was being created and it was only 
carrying over the username and password, not the rest of the settings. Drove me 
up the wall for a few hours. I was hoping someone else knew what the source of 
this behavior was but i couldn't find it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to