rmannibucau commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661093235
Well there are multiple options: 1. Do nothing (we keep these issues) - don't think it would be good 2. Do a global not thread safe lock (and you fix a few issues but create new issues and slow down builds when enabled) 3. Do a concurrent lock mecanism (as https://github.com/takari/takari-local-repository/blob/master/src/main/java/io/takari/aether/concurrency/LockingSyncContext.java) I think 2 solves as much as it breaks so I'd like to ensure if it is done that it is compatible with 3. Current impl seems to stack workarounds (lock counter means locking is not cleanly handled in resolver, global locking API vs per artifact or worse case per groupId). I'd also add that on windows this kind of impl can just lock silently and never end (so can need a timeout?) :(. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
