michael-o commented on pull request #65:
URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661272254


   Please explain point 2. Why do you consider it as non-thread safe? The lock 
itself is thread-safe and can be passed around. That's the hole point. The 
`SyncContext` does not has to be.
   3. This one is broken too, mentioned numerous times in tickets and on GitHub.
   
   Why does 2 has to be compatible with 3? It has only to comply with the API 
contract. There is no current implementation, it is a no-op. Also there is no 
global locking API in the code whatsoever. The global locking is a design 
decision for this specific implementation. 
   
   > I'd also add that on windows this kind of impl can just lock silently and 
never end (so can need a timeout?) :(.
   
   Please explain why this is a problem on Windows.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to