mabrarov commented on a change in pull request #33:
URL: https://github.com/apache/maven-ear-plugin/pull/33#discussion_r548752603
##########
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java
##########
@@ -101,6 +101,16 @@
*/
protected String libDirectory;
+ /**
+ * If module is considered for inclusion into the Class-Path entry of
MANIFEST.mf of other modules. {@code false}
+ * value leads to removal of the module from the Class-Path entry. {@code
true} value leads to modification of the
+ * reference to the module in the Class-Path entry if such reference
exists or leads to adding of the module into
+ * the Class-Path entry if such reference doesn't exist. Removal,
modification or adding of the reference in the
+ * Class-Path entry depends on libDirectory property of another module and
on skinnyWars / skinnyModules parameters
+ * of EAR Plugin.
+ */
+ protected Boolean classPathItem = Boolean.FALSE;
Review comment:
`boolean` was my original decision, but there is `excluded` field which
has `Boolean` type by some (not clear to me) reason, so I decided to follow
existing design (if any).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
