mabrarov commented on a change in pull request #33:
URL: https://github.com/apache/maven-ear-plugin/pull/33#discussion_r548753138



##########
File path: src/main/java/org/apache/maven/plugins/ear/EarModule.java
##########
@@ -119,4 +119,17 @@ void resolveArtifact( Set<Artifact> artifacts )
      */
     String getLibDir();
 
+    /**
+     * Returns the bundle file name. If {@code null}, the artifact's file name 
is returned.
+     *
+     * @return the bundle file name
+     */
+    String getBundleFileName();
+
+    /**
+     * If module should present in the Class-Path entry of MANIFEST.mf. 
Doesn't impact Class-Path entry of MANIFEST.mf

Review comment:
       `be included` looks a little bit inaccurate (while I prefer this 
wording). The module won't `be added` into the Class-Path if it's already 
referenced there. Won't `be included` mess with `be added` in this case?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to