elharo commented on a change in pull request #33:
URL: https://github.com/apache/maven-ear-plugin/pull/33#discussion_r548756357
##########
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java
##########
@@ -101,6 +101,16 @@
*/
protected String libDirectory;
+ /**
+ * If module is considered for inclusion into the Class-Path entry of
MANIFEST.mf of other modules. {@code false}
+ * value leads to removal of the module from the Class-Path entry. {@code
true} value leads to modification of the
+ * reference to the module in the Class-Path entry if such reference
exists or leads to adding of the module into
+ * the Class-Path entry if such reference doesn't exist. Removal,
modification or adding of the reference in the
+ * Class-Path entry depends on libDirectory property of another module and
on skinnyWars / skinnyModules parameters
+ * of EAR Plugin.
+ */
+ protected Boolean classPathItem = Boolean.FALSE;
Review comment:
per Effective Java, boolean is preferred
##########
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarMojo.java
##########
@@ -272,8 +272,8 @@ public void execute()
// Now we have everything let's built modules which have not been
excluded
ScopeArtifactFilter filter = new ScopeArtifactFilter(
Artifact.SCOPE_RUNTIME );
- allJarModules = new ArrayList<JarModule>();
- providedJarModules = new ArrayList<JarModule>();
+ allEarModules = new ArrayList<EarModule>();
Review comment:
Yes, we now require Java 7. In general, you do not need to be consistent
with existing code that has problems.
##########
File path: src/main/java/org/apache/maven/plugins/ear/EarModule.java
##########
@@ -119,4 +119,17 @@ void resolveArtifact( Set<Artifact> artifacts )
*/
String getLibDir();
+ /**
+ * Returns the bundle file name. If {@code null}, the artifact's file name
is returned.
+ *
+ * @return the bundle file name
+ */
+ String getBundleFileName();
+
+ /**
+ * If module should present in the Class-Path entry of MANIFEST.mf.
Doesn't impact Class-Path entry of MANIFEST.mf
Review comment:
I'm not sure but "should present" is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
