elharo commented on a change in pull request #18:
URL: 
https://github.com/apache/maven-common-artifact-filters/pull/18#discussion_r624488513



##########
File path: pom.xml
##########
@@ -108,11 +114,23 @@
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-core</artifactId>
       <version>${maven.version}</version>
+      <exclusions>

Review comment:
       why the exclusion? I'd expect this change to resolve a conflict, not 
introduce one that needs to be excluded. Absent a conflict, we should pull in 
transitive dependencies since we can expect that this dependency depends on 
that. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to