cstamas commented on a change in pull request #18:
URL:
https://github.com/apache/maven-common-artifact-filters/pull/18#discussion_r624654698
##########
File path: pom.xml
##########
@@ -108,11 +114,23 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${maven.version}</version>
+ <exclusions>
Review comment:
Um, I don't quite understand:
* we are making sure THIS module is plexus-free, to achieve that we are
making sure no plexus enters it's classpath (hence the exclusions)
* "transitive dependencies might be needed", due above, this implies that
some consumer of this module "might still need" plexus? My stance then is that
consumer dependencies are badly set up (using something that is not a
dependency), wouldn't in that case
https://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html
trigger an alarm? So when consumer dependencies are changed (version of
m-common-a-f upped), at the same time that consumer should be a) de-plexusized
as well, or b) have it's deps properly set up.
My 5 cents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
