cstamas commented on a change in pull request #18:
URL:
https://github.com/apache/maven-common-artifact-filters/pull/18#discussion_r624680594
##########
File path: pom.xml
##########
@@ -108,11 +114,23 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${maven.version}</version>
+ <exclusions>
Review comment:
ack, then assume exclusions were there to make sure (during dev) that
this project does not depend on any Plexus class (directly or indirectly, as in
class hierarchy). As this project depends on maven-core and many other maven
internals, I added exclusion (as even Maven 4 still brings plexus). So, will
remove exclusions as PR builds ok with it in place, hence it proves the point
that this project is plexus-free.
Still, my stance is that downstream projects are simply wrong if they
**expect** plexus as transitive dependency from this project, which, given this
dependency is meant to be consumed as maven plugin or maven extension
dependency is already granted even with Maven 4.
IMO, exclusions are "necessary evil", as plexus originates (and will
originate) from maven-core, and it will be the LAST project to have plexus
removed. But until then, we must make sure all "downstream" projects like this
one, are plexus-free, and is prepared to the moment where dependency on
maven-core will NOT automatically mean "plexus is here!"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
