cstamas commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894246793
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java:
##########
@@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean
filtering, List<FileUtils.Filt
}
FileUtils.copyFile( from, to, encoding, new
FileUtils.FilterWrapper[0], overwrite );
}
-
- buildContext.refresh( to );
Review Comment:
... and my 5 cents to whole this topic: I never saw a "plain" (explained
later) Maven project that is fairly more complex than "hello world" and works
OOTB in m2e. Work, as in no "tweaks", "m2e profile in POM" needed etc. OTOH, I
did saw Maven project using takari lifecycle that WORK perfectly and OOTB in
m2e.
But alas, takari lifecycle use the "inferior" incrementalbuild and not
buildcontext API. Oh, and it also replaces many things from Maven itself, and
even ditches this maven-filtering and replaces it's with it's own to be
functional :smile:
("plain" as Maven build w/o any extension, while takari-lifecycle is an
extension and replaces a LOT from maven, like core copmponets but also shared
stuff like this maven-filtering and many plugins as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
