olamy commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894235164


##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java:
##########
@@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean 
filtering, List<FileUtils.Filt
                 }
                 FileUtils.copyFile( from, to, encoding, new 
FileUtils.FilterWrapper[0], overwrite );
             }
-
-            buildContext.refresh( to );

Review Comment:
   > If I get it correctly, what you say is "buildcontext prevails over 
takari/incrementalbuild as m2e has more commits"? 🦘 LOL, well, I am about to 
stop here.... 😆
   
   no sorry but you do not read correctly, the most important is the number of 
users impacted.
   and here in m2e is a lot!
   what is better it's not the question here. 
   again I'm just saying the impacted users number is really huge!
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to