olamy commented on code in PR #38:
URL: https://github.com/apache/maven-filtering/pull/38#discussion_r894089757
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenFileFilter.java:
##########
@@ -105,8 +110,6 @@ public void copyFile( File from, File to, boolean
filtering, List<FileUtils.Filt
}
FileUtils.copyFile( from, to, encoding, new
FileUtils.FilterWrapper[0], overwrite );
}
-
- buildContext.refresh( to );
Review Comment:
it's not a rant. you point to a repo mentioning it's the logical successor.
whereas my point is by removing this you will affect all m2e users which is
probably hundreds thousands even million(s) of users.
By pointing the repo I'm just saying m2e has a lot of
contribution/maintenance and users compared to the repo you mention.
Even if I agree this was a bad idea/design (and as the guy who started the
maven-filtering I didn't like it long time ago neither but it has been done...)
but now it's here and use by a **lot** of people.
so we live with that or we discuss with m2e folks a replacement solution or
at least ask them what are the impacts removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
