cstamas commented on code in PR #335:
URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355562042
##########
pom.xml:
##########
@@ -85,18 +85,21 @@
<properties>
<javaVersion>8</javaVersion>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ <maven.compiler.release>${javaVersion}</maven.compiler.release>
<surefire.redirectTestOutputToFile>true</surefire.redirectTestOutputToFile>
<failsafe.redirectTestOutputToFile>${surefire.redirectTestOutputToFile}</failsafe.redirectTestOutputToFile>
<maven.site.path>resolver-archives/resolver-LATEST</maven.site.path>
<checkstyle.violation.ignore>None</checkstyle.violation.ignore>
- <sisuVersion>0.3.5</sisuVersion>
- <guiceVersion>5.1.0</guiceVersion>
+ <sisuVersion>0.9.0.M2</sisuVersion>
+ <guiceVersion>6.0.0</guiceVersion>
<slf4jVersion>1.7.36</slf4jVersion>
<!-- used by supplier and demo only -->
- <mavenVersion>3.9.4</mavenVersion>
- <minimalMavenBuildVersion>[3.8.7,)</minimalMavenBuildVersion>
- <minimalJavaBuildVersion>[1.8.0-362,)</minimalJavaBuildVersion>
-
<project.build.outputTimestamp>2023-09-22T18:13:46Z</project.build.outputTimestamp>
+ <mavenVersion>3.9.5</mavenVersion>
+ <minimalMavenBuildVersion>[3.8.8,)</minimalMavenBuildVersion>
+ <minimalJavaBuildVersion>[17.0.6,)</minimalJavaBuildVersion>
Review Comment:
There ARE technical (and human) justifications. For example, remember this
thread? :smile:
https://lists.apache.org/thread/k5sc3w7w4xkgjfzyxxltg06722dvspk7
In short, we tend to say "Java 8" but there are important **Java updates**,
hence there is java 8u172 from 2018 and Java 8u371 from 2023. This thread
**happened** to us, and clearly shows there is sense to set "lower limit". I
just dont want to waste my time and resources on things like happened in that
thread anymore.
This limit simply says (and means) "**recent Java 17**" and NOT "**just any
java 17**" as we used to say so far. This is far better, explicit, and even the
error message makes sense as shown here:
https://lists.apache.org/thread/tz4qfqhvrvf2fr84l8loqsfpmcf5poz4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
