gnodet commented on code in PR #335:
URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1357237735
##########
pom.xml:
##########
@@ -85,18 +85,21 @@
<properties>
<javaVersion>8</javaVersion>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ <maven.compiler.release>${javaVersion}</maven.compiler.release>
<surefire.redirectTestOutputToFile>true</surefire.redirectTestOutputToFile>
<failsafe.redirectTestOutputToFile>${surefire.redirectTestOutputToFile}</failsafe.redirectTestOutputToFile>
<maven.site.path>resolver-archives/resolver-LATEST</maven.site.path>
<checkstyle.violation.ignore>None</checkstyle.violation.ignore>
- <sisuVersion>0.3.5</sisuVersion>
- <guiceVersion>5.1.0</guiceVersion>
+ <sisuVersion>0.9.0.M2</sisuVersion>
+ <guiceVersion>6.0.0</guiceVersion>
<slf4jVersion>1.7.36</slf4jVersion>
<!-- used by supplier and demo only -->
- <mavenVersion>3.9.4</mavenVersion>
- <minimalMavenBuildVersion>[3.8.7,)</minimalMavenBuildVersion>
- <minimalJavaBuildVersion>[1.8.0-362,)</minimalJavaBuildVersion>
-
<project.build.outputTimestamp>2023-09-22T18:13:46Z</project.build.outputTimestamp>
+ <mavenVersion>3.9.5</mavenVersion>
+ <minimalMavenBuildVersion>[3.8.8,)</minimalMavenBuildVersion>
+ <minimalJavaBuildVersion>[17.0.6,)</minimalJavaBuildVersion>
Review Comment:
Imho, I would keep it as low as needed, but certainly would not put any
barrier in raising the build time requirement. This would allow using
multi-release JARs if needed or even leverage new JEP such as FFM (for
accessing native code or memory). Whatever is needed at build time should be
fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
