cstamas commented on code in PR #335:
URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355576036
##########
pom.xml:
##########
@@ -85,18 +85,21 @@
<properties>
<javaVersion>8</javaVersion>
+ <maven.compiler.source>${javaVersion}</maven.compiler.source>
+ <maven.compiler.target>${javaVersion}</maven.compiler.target>
+ <maven.compiler.release>${javaVersion}</maven.compiler.release>
<surefire.redirectTestOutputToFile>true</surefire.redirectTestOutputToFile>
<failsafe.redirectTestOutputToFile>${surefire.redirectTestOutputToFile}</failsafe.redirectTestOutputToFile>
<maven.site.path>resolver-archives/resolver-LATEST</maven.site.path>
<checkstyle.violation.ignore>None</checkstyle.violation.ignore>
- <sisuVersion>0.3.5</sisuVersion>
- <guiceVersion>5.1.0</guiceVersion>
+ <sisuVersion>0.9.0.M2</sisuVersion>
+ <guiceVersion>6.0.0</guiceVersion>
<slf4jVersion>1.7.36</slf4jVersion>
<!-- used by supplier and demo only -->
- <mavenVersion>3.9.4</mavenVersion>
- <minimalMavenBuildVersion>[3.8.7,)</minimalMavenBuildVersion>
- <minimalJavaBuildVersion>[1.8.0-362,)</minimalJavaBuildVersion>
-
<project.build.outputTimestamp>2023-09-22T18:13:46Z</project.build.outputTimestamp>
+ <mavenVersion>3.9.5</mavenVersion>
+ <minimalMavenBuildVersion>[3.8.8,)</minimalMavenBuildVersion>
+ <minimalJavaBuildVersion>[17.0.6,)</minimalJavaBuildVersion>
Review Comment:
I can, but why would I? I want to add modules that do HTTP/2, and require
Java11+, moreover, for testing those I may want to use dependencies (test
scoped) that are Java17...
What would limiting build time Java requirement to 8u300 help with those
above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
