jbliznak commented on code in PR #3252: URL: https://github.com/apache/maven-surefire/pull/3252#discussion_r2778266400
########## surefire-booter/src/main/java/org/apache/maven/surefire/booter/ProcessHandleChecker.java: ########## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.surefire.booter; + +import javax.annotation.Nonnull; + +import java.lang.reflect.Method; +import java.util.Optional; + +import static org.apache.maven.surefire.api.util.ReflectionUtils.invokeMethodWithArray; +import static org.apache.maven.surefire.api.util.ReflectionUtils.tryGetMethod; +import static org.apache.maven.surefire.api.util.ReflectionUtils.tryLoadClass; + +/** + * Checks if a process is alive using the ProcessHandle API via reflection. + * <p> + * This implementation uses reflection to access the Java 9+ {@code ProcessHandle} API, + * allowing the class to compile on Java 8 while functioning on Java 9+. + * <p> + * The checker detects two scenarios indicating the process is no longer available: + * <ol> + * <li>The process has terminated ({@code ProcessHandle.isAlive()} returns {@code false})</li> + * <li>The PID has been reused by the OS for a new process (start time differs from initial)</li> + * </ol> + * + * @since 3.? Review Comment: this needs to be sorted out before merging, right? ########## surefire-booter/src/main/java/org/apache/maven/surefire/booter/ProcessChecker.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.surefire.booter; + +/** + * Interface for checking if a process (typically the parent Maven plugin) is still alive. + * <p> + * Implementations allow the forked JVM to detect when its parent Maven process + * has terminated, enabling cleanup and preventing orphaned processes. + * + * @since 3.? Review Comment: this needs to be sorted out before merging, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
