michael-o commented on code in PR #3252: URL: https://github.com/apache/maven-surefire/pull/3252#discussion_r2779097726
########## surefire-booter/src/main/java/org/apache/maven/surefire/booter/ProcessChecker.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.surefire.booter; + +/** + * Interface for checking if a process (typically the parent Maven plugin) is still alive. + * <p> + * Implementations allow the forked JVM to detect when its parent Maven process + * has terminated, enabling cleanup and preventing orphaned processes. + * + * @since 3.? + */ +public interface ProcessChecker { + + /** + * Creates the appropriate {@link ProcessChecker} implementation for the given parent PID. + * <p> + * On Java 9+, uses {@code ProcessHandleChecker} which leverages the {@code ProcessHandle} API. + * On Java 8, falls back to {@link PpidChecker} which uses native commands. + * + * @param ppid the parent process ID as a string, or {@code null} + * @return a new checker instance, or {@code null} if ppid is {@code null} + */ + static ProcessChecker of(String ppid) { Review Comment: I assumed so... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
