ascheman opened a new pull request, #428:
URL: https://github.com/apache/maven-integration-testing/pull/428
@gnodet — for review. Companion to apache/maven#12333 (which backports
the core fix from #12297 / #12298 to the maven-3.10.x line).
## What this PR adds
Three integration tests in
`MavenITgh12288SettingsProfileAetherPropertiesTest`:
* `testActiveByDefaultProfile` — guards that a settings.xml profile
activated via `<activation><activeByDefault>true</activeByDefault>`
has its `<properties>` (notably `aether.*`) propagated to the resolver
session config in time for LRM init.
* `testActiveProfilesList` — guards the
`<activeProfiles><activeProfile>...</activeProfile></activeProfiles>`
channel that already worked on 3.x. Acts as a regression guard so the
channel keeps working after the activeByDefault fix.
* `testActiveByDefaultDeactivatedViaCli` — guards that `-P !profileId`
still deactivates an `<activeByDefault>` profile after the fix, so its
`<properties>` are NOT merged into the resolver session config.
All three tests use the same fixture artifact
(`org.apache.maven.its.settings.profile.aether:test-artifact:1.0:pom`)
and assert the install location under
`<localRepo>/it-custom-prefix/...` — the place
`aether.enhancedLocalRepository.localPrefix` would land it iff the
properties reach the session config.
## Adaptations from master
Equivalent ITs on apache/maven master were merged via #12297 and #12298.
Ported with the following 3.x conventions:
* `java.io.File` API instead of `java.nio.file.Path`
* `Verifier` from `org.apache.maven.shared.verifier` (3.x package)
* `ResourceExtractor.simpleExtractResources` for fixture extraction
* JUnit-4-style assertions inherited from
`AbstractMavenIntegrationTestCase`
* Resource directory uses 3.x `gh-NNNN` naming convention
* `super("[3.10.0-SNAPSHOT,)")` so the IT only runs once the core
backport (apache/maven#12333) lands
## CI behaviour
Until apache/maven#12333 is merged and a Maven 3.10.0 build with the fix
is what the IT-suite runs against, the IT will be **skipped** by the
version-range constraint — green-by-skip is the expected state for now.
## Master origin commits
* apache/maven `7725eaf25ab2715b26848fa56d3f0416862e83cb` — initial 2 ITs
* apache/maven `578523519a33a78a651c472bb07d312e01b1e521` — rename + review
hardening
* apache/maven `22f9a0ee086a464f2bfa757ecd0a32053f3d1e8d` — squashed merge
of #12298 (added `testActiveByDefaultDeactivatedViaCli`)
References apache/maven#12288, apache/maven#12333.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
