gnodet commented on PR #428:
URL:
https://github.com/apache/maven-integration-testing/pull/428#issuecomment-4776692485
_Claude Code on behalf of Guillaume Nodet_
Here's a patch for the two issues flagged in the review. You can apply it
with `git apply`:
<details>
<summary>Patch: Fix Spotless formatting and add TestSuiteOrdering
registration</summary>
```diff
diff --git
a/core-it-suite/src/test/java/org/apache/maven/it/MavenITgh12288SettingsProfileAetherPropertiesTest.java
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITgh12288SettingsProfileAetherPropertiesTest.java
index c262829e5..50471617f 100644
---
a/core-it-suite/src/test/java/org/apache/maven/it/MavenITgh12288SettingsProfileAetherPropertiesTest.java
+++
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITgh12288SettingsProfileAetherPropertiesTest.java
@@ -77,8 +77,8 @@ public class
MavenITgh12288SettingsProfileAetherPropertiesTest extends AbstractM
@Test
public void testActiveByDefaultDeactivatedViaCli() throws Exception {
- File testDir = ResourceExtractor.simpleExtractResources(
- getClass(), "/gh-12288-settings-profile-aether-properties");
+ File testDir =
+ ResourceExtractor.simpleExtractResources(getClass(),
"/gh-12288-settings-profile-aether-properties");
Verifier verifier = newVerifier(testDir.getAbsolutePath());
verifier.setAutoclean(false);
@@ -111,8 +111,8 @@ public class
MavenITgh12288SettingsProfileAetherPropertiesTest extends AbstractM
}
private void runAndAssertCustomPrefix(String settingsFile) throws
Exception {
- File testDir = ResourceExtractor.simpleExtractResources(
- getClass(), "/gh-12288-settings-profile-aether-properties");
+ File testDir =
+ ResourceExtractor.simpleExtractResources(getClass(),
"/gh-12288-settings-profile-aether-properties");
Verifier verifier = newVerifier(testDir.getAbsolutePath());
verifier.setAutoclean(false);
diff --git
a/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java
b/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java
index c9bd8e395..8acd0b027 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java
@@ -121,6 +121,7 @@ public class TestSuiteOrdering implements ClassOrderer {
* a fail fast technique as well.
*/
+
suite.addTestSuite(MavenITgh12288SettingsProfileAetherPropertiesTest.class);
suite.addTestSuite(MavenITgh10312TerminallyDeprecatedMethodInGuiceTest.class);
suite.addTestSuite(MavenITgh10937QuotedPipesInMavenOptsTest.class);
suite.addTestSuite(MavenITmng8106OverlappingDirectoryRolesTest.class);
```
</details>
Alternatively, run `mvn spotless:apply -pl core-it-suite` for the formatting
fix and manually add the `TestSuiteOrdering` line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
