gnodet commented on code in PR #428: URL: https://github.com/apache/maven-integration-testing/pull/428#discussion_r3457469690
########## core-it-suite/src/test/java/org/apache/maven/it/MavenITgh12288SettingsProfileAetherPropertiesTest.java: ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.it; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.Comparator; + +import org.apache.maven.shared.verifier.Verifier; +import org.apache.maven.shared.verifier.util.ResourceExtractor; +import org.junit.jupiter.api.Test; + +/** + * Integration tests proving that {@code aether.*} properties declared in the + * {@code <properties>} block of a {@code settings.xml} profile are honored + * by the resolver at local repository manager initialization, regardless of + * which settings.xml-only activation channel was used. + * + * <p>Two activation channels are covered: + * <ul> + * <li>{@code <activation><activeByDefault>true</activeByDefault></activation>} + * on the profile itself;</li> + * <li>{@code <activeProfiles><activeProfile>...</activeProfile></activeProfiles>} + * at the top of {@code settings.xml}.</li> + * </ul> + * + * <p>In both cases the same profile sets: + * <pre> + * aether.enhancedLocalRepository.split = true + * aether.enhancedLocalRepository.localPrefix = it-custom-prefix + * </pre> + * and the test asserts that {@code mvn install} writes the installed pom + * under {@code <localRepo>/it-custom-prefix/<groupId-path>/...} rather + * than the flat or default-split layout. + * + * <p>A third test ({@code testActiveByDefaultDeactivatedViaCli}) guards + * that {@code -P !profileId} still deactivates an {@code <activeByDefault>} + * profile, so its {@code <properties>} are NOT merged into the resolver + * session config. + * + * <p>Backport target: requires the fix from apache/maven PR #12333 to be + * present in the running Maven 3.10.x build. + */ +public class MavenITgh12288SettingsProfileAetherPropertiesTest extends AbstractMavenIntegrationTestCase { + + public MavenITgh12288SettingsProfileAetherPropertiesTest() { + super("[3.10.0-SNAPSHOT,)"); + } + + @Test + public void testActiveByDefaultProfile() throws Exception { + runAndAssertCustomPrefix("settings-active-by-default.xml"); + } + + @Test + public void testActiveProfilesList() throws Exception { + runAndAssertCustomPrefix("settings-active-profiles-list.xml"); + } + + @Test + public void testActiveByDefaultDeactivatedViaCli() throws Exception { + File testDir = ResourceExtractor.simpleExtractResources( + getClass(), "/gh-12288-settings-profile-aether-properties"); + + Verifier verifier = newVerifier(testDir.getAbsolutePath()); + verifier.setAutoclean(false); + verifier.setLogFileName("log-deactivation.txt"); + verifier.deleteDirectory("target"); + verifier.deleteArtifacts("org.apache.maven.its.settings.profile.aether"); + + File customPrefixSubtree = new File(verifier.getLocalRepository(), "it-custom-prefix"); + deleteRecursivelyIfExists(customPrefixSubtree); + + verifier.addCliArgument("--settings"); + verifier.addCliArgument("settings-active-by-default.xml"); + verifier.addCliArgument("-P!aether-split-via-settings"); + verifier.addCliArgument("install"); + verifier.execute(); + verifier.verifyErrorFreeLog(); + + String localRepo = verifier.getLocalRepository(); + String gavRelativePath = "org/apache/maven/its/settings/profile/aether/test-artifact/1.0/test-artifact-1.0.pom"; + File flatLayout = new File(localRepo, gavRelativePath); + File customPrefix = new File(localRepo, "it-custom-prefix/" + gavRelativePath); + + assertTrue( + "Expected artifact at flat layout (profile deactivated via -P !), but not found at " + flatLayout, + flatLayout.exists()); + + assertFalse( + "Found artifact at custom prefix " + customPrefix + " - deactivation via -P ! was ignored.", + customPrefix.exists()); + } + + private void runAndAssertCustomPrefix(String settingsFile) throws Exception { + File testDir = ResourceExtractor.simpleExtractResources( + getClass(), "/gh-12288-settings-profile-aether-properties"); + + Verifier verifier = newVerifier(testDir.getAbsolutePath()); + verifier.setAutoclean(false); + verifier.deleteDirectory("target"); Review Comment: Spotless expects different line wrapping here. CI shows the expected format is: ```suggestion File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/gh-12288-settings-profile-aether-properties"); ``` Running `mvn spotless:apply` will fix this and the other violation automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
