gnodet-bot commented on PR #12695: URL: https://github.com/apache/maven/pull/12695#issuecomment-5729224280
**[Low] `MavenJulHandlerTest` deleted with no replacement.** `impl/maven-logging/src/test/java/org/apache/maven/slf4j/MavenJulHandlerTest.java` was deleted (-151 lines). The `MavenJulHandler` gained new `LogSink`-aware code in this PR (the `if (sink != null)` path at line 136+), but that path has zero test coverage now. At minimum, two scenarios should be tested: 1. When a `LogSink` is installed: JUL records should be forwarded to the sink directly (bypassing SLF4J) 2. When no `LogSink` is installed: JUL records should fall through to SLF4J for console output _This review was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
