rmannibucau commented on code in PR #854:
URL:
https://github.com/apache/maven-shade-plugin/pull/854#discussion_r4061833248
##########
src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java:
##########
@@ -191,12 +191,11 @@ private boolean removeServicesFromDir(Clazzpath cp,
Set<Clazz> neededClasses, St
continue;
}
- try (BufferedReader configFileReader =
- new BufferedReader(new InputStreamReader(new
FileInputStream(serviceProviderConfigFile), UTF_8))) {
+ try (BufferedReader configFileReader =
Files.newBufferedReader(serviceProviderConfigFile.toPath(), UTF_8)) {
// check whether the found classes use services in turn
repeatScan |= scanServiceProviderConfigFile(cp,
configFileReader);
} catch (final IOException e) {
- log.warn(e.getMessage());
+ log.warn("Failed to scan service provider config file " +
serviceProviderConfigFile, e);
Review Comment:
think it is saner to keep it together (or totally duplicate the line) cause
loggers are not output streams, warn and debug can be routed to different
output and there is no order delivery guarantee between them if executed super
fast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
