michael-o commented on code in PR #854:
URL:
https://github.com/apache/maven-shade-plugin/pull/854#discussion_r4069118066
##########
src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java:
##########
@@ -222,11 +221,11 @@ private boolean removeServicesFromJar(Clazzpath cp,
Set<Clazz> neededClasses, St
// check whether the found classes use services in turn
repeatScan = scanServiceProviderConfigFile(cp,
configFileReader);
} catch (final IOException e) {
- log.warn(e.getMessage());
+ log.warn("Failed to scan JAR entry " + jarEntry.getName(),
e);
}
}
} catch (final IOException e) {
- log.warn("Not a JAR file candidate. Ignoring classpath element '"
+ fileName + "' (" + e + ").");
+ log.warn("Not a JAR file candidate. Ignoring classpath element '"
+ fileName + "'", e);
Review Comment:
No, see above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
